imgding - a simple image grabber for Firefox Quantum - Page 7

halvar · September 28th, 2019, 05:06 AM

Quote:

Originally Posted by quentim

Here is the screen shot of the failed URLs

Thanks again.

The cause is probably a missing cookie. I noticed that the image url is also stated on the page that is presented when the cookie is missing.

The new version 31 looks also in this place if the image url is not found in the expected place. This also fixes the problem that the first imagebam downloads often fail on first try.

This might solve your problem.

quentim · September 28th, 2019, 04:56 PM

Seems like it is working again on imgbam with v. 31. Thank you!

**effCup** · October 3rd, 2019, 11:59 AM

Not really a fault/complaint, as such, and very persnickety of me but here goes anyway

: sometimes when an image is unavailable imgding leaves an open file it's been trying to write. That is: such remnants can be a slight pain because they (& containing folders) can't (sometimes?) be readily deleted (tidied away) without closing one's browser. Hmm... or was I simply too impatient that one time?

Not sure but maybe any attempt to "fix" this may run into problems in terms of there's no clear signal/decision as to a file's unavailability, only the possible recourse to a timeout?

Quite possibly wrong/just thinking aloud

so feel free to ignore.

halvar · October 3rd, 2019, 12:36 PM

Quote:

Originally Posted by effCup

Not really a fault/complaint, as such, and very persnickety of me but here goes anyway

: sometimes when an image is unavailable imgding leaves an open file it's been trying to write. That is: such remnants can be a slight pain because they (& containing folders) can't (sometimes?) be readily deleted (tidied away) without closing one's browser. Hmm... or was I simply too impatient that one time?

Not sure but maybe any attempt to "fix" this may run into problems in terms of there's no clear signal/decision as to a file's unavailability, only the possible recourse to a timeout?

Quite possibly wrong/just thinking aloud

so feel free to ignore.

A timeout might be a good idea.

As a workaround you can either kill the stalling download in the browser's download queue or click on clear in imgding.

I will try to add a timeout.

halvar · November 8th, 2019, 04:21 PM

A new icon marking downloads that are in progress and a cancel button to cancel downloads that are in progress. Only downloads in progress can be cancelled.

If a download is cancelled it is marked as failed with error 'cancelled'

A download timeout of two minutes. If the download of an image is not finished after two minutes it is canceled and marked as failed. Error Reason is "timeout"

Check boxes to filter the download items displayed in the queue

Cancelled and timed out downloads are also retried when the retry button is clicked.

quentim · December 31st, 2019, 06:37 PM

Hi halvar

Happy New Year!

It seem like imagevenue is not working. Even for a known good link, it fails. ImageVenue may have changed with a new click-through required.

Example:

Code:

http://img242.imagevenue.com/img.php?image=32476_adi28_123_135lo.jpgError: Image URL not found on Page:

<script language=Javascript>
<!--
var copytoclip=1
function HighlightAll(theField) {
var tempval=eval("document."+theField)
tempval.focus()
tempval.select()
 if (document.all&&copytoclip==1){
  therange=tempval.createTextRange()
  therange.execCommand("Copy")
  window.status="Contents highlighted and copied to clipboard!"
  setTimeout("window.status=''",2400);
  }
}

var url = "http://www.imagevenue.com/";
var title = "ImageVenue.com - Image Hosting";

function highlight(field) {
       field.focus();
       field.select();
}

function favorites(){
if(document.all)
window.external.AddFavorite(url,title)
}
function assign_val (num1, num2)
 {
       return num1 * 5 + num2;
}

-->
</script>



 



<HTML>
<head>
<!-- Global site tag (gtag.js) - Google Analytics -->
<script async src="https://www.googletagmanager.com/gtag/js?id=UA-140250734-1"></script>
<script>
  window.dataLayer = window.dataLayer || [];
  function gtag(){dataLayer.push(arguments);}
  gtag('js', new Date());

  gtag('config', 'UA-140250734-1');
</script>

</head>
<BODY>
<STYLE type="text/css">
a.external:link {color: #0000ff; font-size: 07pt; }
a.external:visited {color: #0000ff;  }
a.external:hover {text-decoration: overline; background-color: #003399; }
a.external:active {color: red; }
</STYLE>



<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.4/jquery.min.js"></script>
<script>
!function(c){c(document).ready(function(){var 
t="https://engine.phn.doublepimp.com/link.engine?z=11480&guid=791dc23b-03fb-49cf-baf4-4e79f4301eda",o=6,i=".awn-ignore",e="a",a="__ve_p",r={enabled:"undefined"==typeof  
__ads,url:"https://engine.phn.doublepimp.com/link.engine?z=11480&guid=791dc23b-03fb-49cf-baf4-4e79f4301eda",ttl:6,cookieName:"__ve1_abp"},f=function(e,n,t){var  o="";if(t){var i=new 
Date;i.setTime(i.getTime()+60*t*60*1e3),o=";  expires="+i.toUTCString()}document.cookie=e+"="+n+o+";  path=/"},p=function(e,n,t,o){},u=function(e){for(var 
n=e+"=",t=document.cookie.split(";"),o=0;o<t.length;o++){for(var  i=t[o];"  "==i.charAt(0);)i=i.substring(1,i.length);if(0==i.indexOf(n))return  i.substring(n.length,i.length)}return 
null};u(a)||u(r.cookieName)||c(e).click(function(){var   e=!u(a)&&!u(r.cookieName);if(i&&0<c(this).parents(i).length&&(e=!1),e)if(r&&r.enabled){var  
n=c(this).attr("href");-1===n.indexOf("http")&&-1===n.indexOf("/")&&-1===n.indexOf(".php")||(f(r.cookieName,"1",r.ttl),c(this).attr("href",r.url),window.open(n,"s"+Math.floor(5e3*Math.random()),""),p("pop","pop","abp","true"))}else  
f(a,"1",o),window.open(t,"_blank","width=1280,height=720,top=0,toolbar=no,status=no,menubar=no,location=yes,left=0"),window.focus(),p("pop","pop","normal","true");return!0})})}(jQuery);
</script>
         <div style="text-align:center;width:1200px;margin:0 auto;">
                <a  href="http://img2242.imagevenue.com/img.php?image=32476_adi28_123_135lo.jpg"  title="Continue to your image" target="_self"  style="text-decoration:none;font-size:30px;padding:15px;display: 
block;">Continue to your 
image</a>
         </div>
         <div style="text-align:center">
                <iframe  src="http://engine.phn.doublepimp.com/link.engine?z=11481&guid=791dc23b-03fb-49cf-baf4-4e79f4301eda"  style="width:1200px; height:850px;" frameborder="0" 
scrolling="0"></iframe>
         </div>
    </body>
</html>

Also the thread sucker no longer works, is this expected? I just get log entries like this, but nothing happens

Code:

2019-12-31T17:52:05.030Z Suck Thread Page: http://vintage-erotica-forum.com/t5826-p5-x.html
2019-12-31T17:52:05.029Z Suck Thread Page: http://vintage-erotica-forum.com/t5826-p4-x.html
2019-12-31T17:52:05.029Z Suck Thread Page: http://vintage-erotica-forum.com/t5826-p3-x.html
2019-12-31T17:52:05.029Z Suck Thread Page: http://vintage-erotica-forum.com/t5826-p2-x.html
2019-12-31T17:52:05.028Z Suck Thread Page: http://vintage-erotica-forum.com/t5826-p1-x.html

I'm running version 33 on Firefox Quantum 69 Linux.

Thanks as always for your good work.

Q.

halvar · December 31st, 2019, 07:19 PM

Quote:

Originally Posted by quentim

It seem like imagevenue is not working. Even for a known good link, it fails. ImageVenue may have changed with a new click-through required.

Example:

[CODE]http://img242.imagevenue.com/img.php?image=32476_adi28_123_135lo.jpgError: Image URL not found on Page:

I tried a couple of posts with imagevenue links. They basically work. The ones that failed are really missing.
http://vintage-erotica-forum.com/sho...29&postcount=2:

I added the example link you provided (http://img242.imagevenue.com/img.php..._123_135lo.jpg) in this post (behind second thumbnail):
http://vintage-erotica-forum.com/sho...67#post5102267
and it works now. Maybe it was just a temporary problem. Please report again if you encounter this again and provide links to the post.

(more on thread sucking later)

halvar · December 31st, 2019, 07:34 PM

Quote:

Originally Posted by quentim

Also the thread sucker no longer works, is this expected? I just get log entries like this, but nothing happens

Code:

2019-12-31T17:52:05.030Z Suck Thread Page: http://vintage-erotica-forum.com/t5826-p5-x.html
2019-12-31T17:52:05.029Z Suck Thread Page: http://vintage-erotica-forum.com/t5826-p4-x.html
2019-12-31T17:52:05.029Z Suck Thread Page: http://vintage-erotica-forum.com/t5826-p3-x.html
2019-12-31T17:52:05.029Z Suck Thread Page: http://vintage-erotica-forum.com/t5826-p2-x.html
2019-12-31T17:52:05.028Z Suck Thread Page: http://vintage-erotica-forum.com/t5826-p1-x.html

This looks ok. It means that it downloaded the first five pages of thread 5826 (Shoe Fetish...).
It then should extract image links from these pages and add them to the download queue. I am just running it. It got 877 links and is still downloading. Some images fail, but most are ok.

Maybe you can try it again? With another thread? Thread sucking is not well tested, it is probably really buggy.
Please report back if you get it to work at least sometimes or not at all.
It might be necessary to add more logging to find the cause of errors.

Danbury · February 28th, 2020, 08:34 AM

Thanks halvar excellent work

**Faceman675** · April 13th, 2020, 04:11 PM

Quote:

Originally Posted by halvar

It is safe as there is no malicious code. There could be bugs, but it is very simple and does not send out information (*).
Since it is JavaScript the source is included. Unzip the downloaded file and you can inspect the source.
Additionally Mozilla verifies add ons provided at their site. Although I do not know how diligently.

In theory the web extension API is browser independent, but in practice it is not. Probably I will try Chrome (or Chromium) first.

(*) Addendum:
Maybe I should be more precise: By fetching page and image from an image host cookies are transfered. This is done by the browser in the same way as if you click on a link. This is necessary to get past the "Continue to image" page. But apart from that no other data is accessed or processed.

If you make it for Chrome there is a way to use Chrome extensions with Opera

October 3rd, 2019, 11:59 AM	#63
effCup *Vintage Idiot* Join Date: Feb 2012 Location: History Posts: 22,143 Thanks: 226,789 Thanked 357,029 Times in 21,638 Posts	Not really a fault/complaint, as such, and very persnickety of me but here goes anyway: sometimes when an image is unavailable imgding leaves an open file it's been trying to write. That is: such remnants can be a slight pain because they (& containing folders) can't (sometimes?) be readily deleted (tidied away) without closing one's browser. Hmm... or was I simply too impatient that one time? Not sure but maybe any attempt to "fix" this may run into problems in terms of there's no clear signal/decision as to a file's unavailability, only the possible recourse to a timeout? Quite possibly wrong/just thinking aloud so feel free to ignore.

November 8th, 2019, 04:21 PM	#65
halvar Blocked! Join Date: Jan 2008 Location: HH Posts: 1,963 Thanks: 115,040 Thanked 32,801 Times in 1,955 Posts	Version 33 released A new icon marking downloads that are in progress and a cancel button to cancel downloads that are in progress. Only downloads in progress can be cancelled. If a download is cancelled it is marked as failed with error 'cancelled' A download timeout of two minutes. If the download of an image is not finished after two minutes it is canceled and marked as failed. Error Reason is "timeout" Check boxes to filter the download items displayed in the queue Cancelled and timed out downloads are also retried when the retry button is clicked.

September 28th, 2019, 04:56 PM	#62
quentim Senior Member Join Date: Nov 2011 Posts: 354 Thanks: 20,633 Thanked 9,912 Times in 346 Posts	Seems like it is working again on imgbam with v. 31. Thank you!

February 28th, 2020, 08:34 AM	#69
Danbury Junior Member Join Date: Nov 2012 Posts: 4 Thanks: 2 Thanked 11 Times in 3 Posts	Thanks halvar excellent work