View Single Post
Old June 14th, 2017, 04:23 PM   #13
halvar
Blocked!
 
Join Date: Jan 2008
Location: HH
Posts: 1,963
Thanks: 115,040
Thanked 32,801 Times in 1,955 Posts
halvar 100000+halvar 100000+halvar 100000+halvar 100000+halvar 100000+halvar 100000+halvar 100000+halvar 100000+halvar 100000+halvar 100000+halvar 100000+
Default

Quote:
Originally Posted by effCup View Post
1) very minor suggestion, maybe too cosmetic to even bother?: you create a folder for the thread & inside that folders for posts with images to save.

I made the mistake of first testing your tool (1.10) on a thread with a very long title, so I've got post folders each with very long titles inside the thread folder with a very long title, i.e.:
I intended to limit the name to 20 characters - and forgot. I will do this in the next version.
This could be a problem with Windows because it has a maximum length of file paths.

Quote:
Originally Posted by effCup View Post
The post folders only need: thread id, page, then post id.

Strictly, the post folders really only need the post id, as that is canonical on vef, but the thread id & page are perhaps helpful/reassuring for "humans"?
Yes, this is intended for humans

Quote:
Originally Posted by effCup View Post
2) a more serious problem: it seems to have found only 2 posts in that entire thread with imagebam or imgbox images?

p=576111, p=636725.

but there are posts immediately below that second post that also have imagebam images, for example p=636727, but they have not had their images saved?

I do not think I accidentally "stopped" your tool from completing its task--it got all 312 pages, but seemingly stopped with just 2 posts with images.

I tried to re-run the tool on the same thread but no change/additions.
I cannot reproduce this yet. I tried Thread 33256 on Windows (1.10) and Linux (1.11). Both seem to work.
But I stopped after some images. I understood it didn't work at all.
I am currently running the whole thread and have to wait until it reaches one of the failed posts.
halvar is offline   Reply With Quote